If allowedApis is provided respect that always#774
Merged
Conversation
| if (allowedApis != null) { | ||
| // User explicitly specified allowed APIs - use only those | ||
| bundleBuilder.exposedOperations(allowedApis); | ||
| } else if (readOnlyApis == null || readOnlyApis) { |
Collaborator
There was a problem hiding this comment.
This else should be removed
Contributor
Author
There was a problem hiding this comment.
Just removing the else doesn't work for when allowedApis are provided and readOnlyApis isn't.
rhernandez35
force-pushed
the
adwsingh/fix-aws-bundles-again
branch
from
June 13, 2025 23:46
56d1634 to
723e144
Compare
rhernandez35
enabled auto-merge (rebase)
June 13, 2025 23:47
adwsingh
disabled auto-merge
June 13, 2025 23:55
adwsingh
force-pushed
the
adwsingh/fix-aws-bundles-again
branch
2 times, most recently
from
June 14, 2025 00:07
b05be7d to
61770a5
Compare
adwsingh
force-pushed
the
adwsingh/fix-aws-bundles-again
branch
from
June 14, 2025 00:11
61770a5 to
5809b83
Compare
rhernandez35
approved these changes
Jun 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
See #772 (comment)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.